Changeset 117

Timestamp:

01/31/07 15:37:32 (2 years ago)

Author:

ingy

Message:

Kwiki used to crash when you gave it a bad action.

Now it redirects to something. 'index.cgi?404' by default.

Files:

• trunk/src/core/Kwiki/lib/Kwiki/Hub.pm (modified) (1 diff)
• trunk/src/core/Spoon/lib/Spoon/Hub.pm (modified) (2 diffs)

trunk/src/core/Kwiki/lib/Kwiki/Hub.pm

@@ -7 +7 @@
-    'display';
-}
+
+sub unknown_action {
+    my $action = shift;
+    return $self->headers->redirect($self->unknown_action_url);
+}
+
+sub unknown_action_url {
+    return $self->config->{unknown_action_url} || 'index.cgi?404';
+}

trunk/src/core/Spoon/lib/Spoon/Hub.pm

@@ -32 +32 @@
-    $self->preload;
-    my $action = $self->action;
-die "No plugin for action '$action'"
+return $self->unknown_action($action)
-      unless defined $self->registry->lookup->action->{$action};
-    my ($class_id, $method) = 
@@ -38 +38 @@
-    $method ||= $action;
-    return $self->$class_id->$method;
+}
+
+sub unknown_action {
+    my $action = shift;
+    die "No plugin for action '$action'";
-}
-